Depositing Rental Transaction Payments

Problem

When using the Deposit Funds command for rentals, paid rental transactions would still show up in the list.

Caught By

User bug report.

Workaround

Ignore them.

Solution

We fixed this problem in the version 4.9 update for Goldenseal rental management software.

Technical Details

Programmer note: code fixed in CReceiptTransaction::HasBeenDeposited. We currently have four different ways to determine whether an item is deposited-- a flag bit, the status, mAmountDeposited, and a run through the payment transactions to look for deposits. We probably should rewrite & simplify this, but it will be tough to do without breaking old data.